readme: Updated example paths#310
Open
MichalTomczakSE wants to merge 4 commits intocrossplane-contrib:mainfrom
Open
readme: Updated example paths#310MichalTomczakSE wants to merge 4 commits intocrossplane-contrib:mainfrom
MichalTomczakSE wants to merge 4 commits intocrossplane-contrib:mainfrom
Conversation
MichalTomczakSE
requested review from
erhancagirici,
lsviben,
sergenyalcin,
turkenf,
turkenh and
ulucinar
as code owners
Signed-off-by: Michal Tomczak <michaltomczakse@gmail.com>
MichalTomczakSE
force-pushed
the
docs/update-paths
branch
from
1f68ddb to
c7e612d
Compare
Signed-off-by: Michal Tomczak <michaltomczakse@gmail.com>
Signed-off-by: Michal Tomczak <michaltomczakse@gmail.com>
Signed-off-by: Michal Tomczak <michaltomczakse@gmail.com>
MichalTomczakSE
force-pushed
the
docs/update-paths
branch
from
22a3c60 to
bd4c032
Compare
Member
|
Thanks for this enhancement, and sorry for the long delay in reviewing it. Since it’s been a long time, could you please rebase the PR? After that, we can merge it into the main branch and include it in the next maintenance release. can you switch the examples from 1.0.4 in your PR to 1.0.6 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
1.0.4).1.0.4).I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
N/A